Skip to content

GitHub Actions: Run pytest on Python 3.14#978

Merged
amilcarlucas merged 1 commit into
ArduPilot:masterfrom
cclauss:patch-2
Oct 27, 2025
Merged

GitHub Actions: Run pytest on Python 3.14#978
amilcarlucas merged 1 commit into
ArduPilot:masterfrom
cclauss:patch-2

Conversation

@cclauss

@cclauss cclauss commented Oct 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

https://www.python.org/downloads/release/python-3140/
Unfortunately, free threaded Python 3.14t fails, so we will drop back to 3.14 for now.

Copilot AI review requested due to automatic review settings October 26, 2025 05:17
@cclauss cclauss requested a review from amilcarlucas as a code owner October 26, 2025 05:17
Copilot AI reviewed Oct 26, 2025
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the GitHub Actions pytest workflow to test against Python 3.14t (the free-threaded build) instead of Python 3.13, enabling validation of the application's compatibility with Python's experimental free-threaded runtime.

Key Changes:

  • Replaced Python 3.13 with Python 3.14t in the test matrix

@cclauss cclauss changed the title GitHub Actions: Run pytest on free threaded Python 3.14t GitHub Actions: Run pytest on Python 3.14 Oct 26, 2025
@cclauss

cclauss commented Oct 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

@overcat, please see the fastcrc==0.3.3 error line 2623 of the Python 3.14t pytest run.

Do we need to add a pytest plugin?

@overcat

overcat commented Oct 26, 2025

Copy link
Copy Markdown

overcat/fastcrc#17
Thank you for reporting this issue. I will release a new version after testing it and confirming there are no problems.

amilcarlucas
amilcarlucas previously approved these changes Oct 26, 2025
View reviewed changes
@amilcarlucas

amilcarlucas commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

Cool stuff, thanks @cclauss

@cclauss

cclauss commented Oct 26, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Let's wait for a https://github.com/overcat/fastcrc/releases > v0.3.3.

@cclauss cclauss marked this pull request as draft October 26, 2025 11:22
@overcat

overcat commented Oct 26, 2025

Copy link
Copy Markdown

https://pypi.org/project/fastcrc/0.3.4/ is ready.

@cclauss cclauss marked this pull request as ready for review October 26, 2025 11:39
amilcarlucas
amilcarlucas previously approved these changes Oct 26, 2025
View reviewed changes

@amilcarlucas amilcarlucas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like all the changes, but the tests are failing :(

@cclauss

cclauss commented Oct 26, 2025

Copy link
Copy Markdown
Contributor Author

Yes. Bottom line seems to be that Matplotlib use of deepcopy() is a blocker.

@amilcarlucas

amilcarlucas commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

I'm trying a workaround here: #980

@amilcarlucas

amilcarlucas commented Oct 26, 2025

Copy link
Copy Markdown
Collaborator

OK, 3.14 is fixed on master now, Thanks for working on this.

Please rebase it and try to fix 3.14t if possible

@cclauss @amilcarlucas
test(pytest): Run pytest on free threaded Python 3.14t
de028cb 
Signed-off-by: Christian Clauss <cclauss@me.com>
@amilcarlucas amilcarlucas merged commit 340f62e into ArduPilot:master Oct 27, 2025
6 checks passed
@amilcarlucas

amilcarlucas commented Oct 27, 2025

Copy link
Copy Markdown
Collaborator

Thanks, merged.

@cclauss cclauss deleted the patch-2 branch October 27, 2025 06:28
@cclauss cclauss mentioned this pull request Oct 31, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments
@amilcarlucas amilcarlucas amilcarlucas left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cclauss @overcat @amilcarlucas